Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error scope tests for Linux/Intel #3141

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Conversation

lokokung
Copy link
Contributor

@lokokung lokokung commented Nov 8, 2023

Fixes the error scope tests on Linux/Intel once the associated fix lands.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@lokokung lokokung changed the title Error scope Fixes error scope tests for Linux/Intel Nov 8, 2023
@lokokung lokokung requested a review from kainino0x November 8, 2023 01:10
src/webgpu/api/validation/error_scope.spec.ts Show resolved Hide resolved
src/webgpu/api/validation/error_scope.spec.ts Outdated Show resolved Hide resolved
@lokokung lokokung merged commit 04c09a8 into gpuweb:main Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants